Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2_control_node] Add the realtime_tools lock_memory method to prevent page faults #1822

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[ros2_control_node] Add the realtime_tools lock_memory method to prevent page faults #1822

wants to merge 3 commits into from
+8 −0

Conversation

saikishor
Copy link
Member

Add lock_memory to avoid page faults and lock the memory at the beginning to physical RAM

@saikishor saikishor changed the title Add the realtime_tools lock_memory method to prevent page faults [ros2_control_node] Add the realtime_tools lock_memory method to prevent page faults Oct 30, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (832602d) to head (48ec00a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1822   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files         120      120           
  Lines       12224    12226    +2     
  Branches     1093     1093           
=======================================
+ Hits        10709    10711    +2     
  Misses       1125     1125           
  Partials      390      390
Flag Coverage Δ
unittests 87.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 89.18% <100.00%> (+0.61%) ⬆️

bmagyar
bmagyar previously approved these changes Oct 31, 2024
View reviewed changes
@bmagyar bmagyar added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Oct 31, 2024
@saikishor @bmagyar
Use lock_memory by default
48ec00a 
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar left review comments

@destogl destogl Awaiting requested review from destogl

@fmauch fmauch Awaiting requested review from fmauch

@mamueluth mamueluth Awaiting requested review from mamueluth

@mcbed mcbed Awaiting requested review from mcbed

@moriarty moriarty Awaiting requested review from moriarty

@olivier-stasse olivier-stasse Awaiting requested review from olivier-stasse

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikishor @bmagyar